This repository has been archived by the owner on Dec 30, 2024. It is now read-only.
Attempt to fix overflow problem in blockquotes #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A problem was discovered in blockquotes for really long text, in particular in the guidelines: 2305567963945518424753102147331756070. The problem was that the number flowed outside the border. That should no longer happen. Below is what should happen instead, though it's hard to be sure how it will look in every case. In Safari on a 16" MacBook Pro with Safari all across the screen it is not a problem but shorter text will be in a smaller box (this means the green box will vary in size depending on what is in it but this does not seem to be a big problem). With Safari in an old iPhone 8 Plus the box can go a bit further beyond the screen width but text does not go beyond the boundary and one can scroll left/right at need. With Safari in an iPhone 14 Pro Max there is currently a cache issue but earlier (when playing with different options) it seemed to fit and in Simulator (in macOS) it looks good. However in Simulator earlier it was fine even when the iPhone 14 Pro Max was not. In responsive mode in Safari with a small width (400px) it is the same result as the iPhone 8 Plus. Finally with Safari in macOS with the window decreased in width it is fine but it already was fine because it doesn't go to the size of a phone (though it has helped fix problems with phones). I have changed the font-style to normal (was italic) in blockquotes also as this way italics can show up specially if requested. The guidelines had some line breaks in the blockquotes that were problematic; these have been removed as they are not necessary and it did not look good either with smaller width screens. More testing will likely be useful but it should be a lot better now.
Does it seem good to you now? I think it works out well .. though maybe not perfectly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A problem was discovered in blockquotes for really long text, in particular in the guidelines: 2305567963945518424753102147331756070. The problem was that the number flowed outside the border. That should no longer happen. Below is what should happen instead, though it's hard to be sure how it will look in every case.
In Safari on a 16" MacBook Pro with Safari all across the screen it is not a problem but shorter text will be in a smaller box (this means the green box will vary in size depending on what is in it but this does not seem to be a big problem).
With Safari in an old iPhone 8 Plus the box can go a bit further beyond the screen width but text does not go beyond the boundary and one can scroll left/right at need.
With Safari in an iPhone 14 Pro Max there is currently a cache issue but earlier (when playing with different options) it seemed to fit and in Simulator (in macOS) it looks good. However in Simulator earlier it was fine even when the iPhone 14 Pro Max was not.
In responsive mode in Safari with a small width (400px) it is the same result as the iPhone 8 Plus.
Finally with Safari in macOS with the window decreased in width it is fine but it already was fine because it doesn't go to the size of a phone (though it has helped fix problems with phones).
I have changed the font-style to normal (was italic) in blockquotes also as this way italics can show up specially if requested.
The guidelines had some line breaks in the blockquotes that were problematic; these have been removed as they are not necessary and it did not look good either with smaller width screens.
More testing will likely be useful but it should be a lot better now.